Skip to content

chore: remove unused loadRefreshToken and loadAccessToken stubs - #32785

Merged
Vishnuujain merged 2 commits into
mainfrom
detail/dead-code/chore-remove-unused-loadrefreshtoken-and-loadacces-4234ca
Sep 7, 2026
Merged

chore: remove unused loadRefreshToken and loadAccessToken stubs#32785
Vishnuujain merged 2 commits into
mainfrom
detail/dead-code/chore-remove-unused-loadrefreshtoken-and-loadacces-4234ca

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Removed the loadRefreshToken(OAuthClientInformation, String) and
loadAccessToken(String) declarations from the
OAuthAuthorizationServerProvider interface, their @Override
implementations in UserSSOOAuthProvider, and the now-unused
org.openmetadata.mcp.auth.AccessToken import.

These were dead code: both overrides threw UnsupportedOperationException
(comments stated "not used in the current implementation") and had zero
production callers and zero test callers. The interface is internal to
OpenMetadata (the MCP SDK jar has no OAuthAuthorizationServerProvider of
its own, so this is not mirroring an external contract).
exchangeRefreshToken and JwtFilter are the live paths that superseded
them. registerClient and revokeToken were left in place: their overrides
are functional rather than stubs.

History

Tooling: Detail: Dead Code

Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from Vishnuujain September 7, 2026 00:25
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

github-actions Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 03a638515441f5420854158c5da531d7c96b17e3 in Playwright run 34111319106, attempt 1.

✅ 557 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 53m 33s

⏱️ Max setup 4m 30s · max shard execution 18m 44s · max shard-job elapsed before upload 21m 46s · reporting 5s

🌐 234.71 requests/attempt · 2.82 app boots/UI scenario · 7.74% common-shard skew

Optimization targets still in progress:

  • Browser traffic was 234.71 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.82 per UI scenario (1630 boots / 578 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 133 0 0 0 0 0
✅ Shard chromium-02 140 0 0 0 0 0
✅ Shard chromium-03 126 0 0 0 0 0
✅ Shard data-asset-rules-01 65 0 0 0 0 0
✅ Shard domain-isolation-01 16 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0

📦 Download artifacts

How to debug locally 
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@detail-app detail-app Bot added the safe to test Add this label to run secure Github workflows on PRs label Sep 7, 2026
@Vishnuujain
Vishnuujain added this pull request to the merge queue Sep 7, 2026
Merged via the queue into main with commit 5c78484 Sep 7, 2026
112 checks passed
@Vishnuujain
Vishnuujain deleted the detail/dead-code/chore-remove-unused-loadrefreshtoken-and-loadacces-4234ca branch September 7, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vishnuujain Vishnuujain Vishnuujain approved these changes

Assignees

@Vishnuujain Vishnuujain

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Vishnuujain